Skip to content

[ready to merge] docs(merge-queue): add stacked PR support section to Chrome Extension page#598

Merged
samgutentag merged 5 commits intomainfrom
sam-gutentag/browser-extension-stacked-prs
May 7, 2026
Merged

[ready to merge] docs(merge-queue): add stacked PR support section to Chrome Extension page#598
samgutentag merged 5 commits intomainfrom
sam-gutentag/browser-extension-stacked-prs

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

Adds a "Stacked pull requests" section to the Chrome Extension docs explaining the new stack-aware panel: stack path display, speculative PR chip with link, and enqueue/cancel behavior that applies to the whole stack. Includes a hint linking to Trunk Sudo requirements.

Source

Test plan

  • Preview in GitBook

Generated by Claude Code

… page

Documents the new stack-aware view added to the browser extension for
stacked PRs queued with /trunk stack: stack path display, speculative
PR chip, and enqueue/cancel behavior for the whole stack.

Source: trunk-io/trunk2#3825

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@trunk-staging-io
Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @samgutentag's task in 2m 0s —— View job


Claude PR Review

  • Read the changed file and PR diff
  • Check for typos, grammar, and formatting issues
  • Compare with related docs for style consistency
  • Post review feedback

Summary

The new Stacked pull requests section is well-scoped, scannable, and matches the page's existing voice and em-dash style. Cross-references (using-the-queue/stacked-pull-requests.md#merge-the-stack-as-one-unit and ../setup-and-administration/trunk-sudo-app.md) resolve correctly. Three issues worth addressing before merge:

  1. Terminology inconsistency on line 51 (blocking) — the bullet calls the UI element a "Speculative PR chip," but the same sentence says it's "labeled Stacked PR #N," and the companion doc using-the-queue/stacked-pull-requests.md uses stacked PR throughout for this combined PR. Calling it both "speculative" and "stacked" in one sentence will confuse readers. See inline comment with a suggestion block.
  2. Tense on line 51 — "the combined test PR Trunk created" → "Trunk creates" (describes general behavior, not a past event). Bundled into the same suggestion above.
  3. Hint placement (lines 60–62) (non-blocking style) — the Trunk Sudo / /trunk stack prerequisite is currently at the bottom of the section. The page's existing convention (lines 8–10) puts prerequisite hints up top so readers don't miss them. Consider moving the {% hint %} directly under the heading.
  4. Minor wording on line 55 (non-blocking) — "Any PR page in the stack triggers the same operation" reads awkwardly; suggested a tighter phrasing inline.

What looks good

  • Heading capitalization (### Stacked pull requests) matches the page's sentence-case style.
  • Em-dash usage matches the existing line 70 style (spaced em-dash).
  • Bold UI labels (**Add to Merge Queue**, **Cancel**) match the conventions used in the Submit a pull request to the queue and Track testing progress sections.
  • The deep link to #merge-the-stack-as-one-unit is correct.

Setting review_passed = false on the strength of issue 1 — the in-sentence terminology contradiction is a real reader-confusion problem that should be resolved before publishing.
Branch

Comment thread merge-queue/chrome-extension.md Outdated
**What the panel shows:**

* **Stack path** — the full list of PRs in the stack from tip to base, so you can see where your PR sits within the group.
* **Speculative PR chip** — a link to the combined test PR Trunk created for the stack (labeled **Stacked PR #N**). Click it to open the speculative PR on GitHub and inspect its CI status.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology inconsistency. This bullet describes the chip as a "Speculative PR chip" but in the same sentence says it is "labeled Stacked PR #N", and asks readers to click to "open the speculative PR." The companion page using-the-queue/stacked-pull-requests.md uses stacked PR consistently for this combined PR (the word "speculative" never describes this PR there — it only appears in the predictive-testing context).

Recommend renaming the chip and aligning the description with the rest of the docs:

Suggested change
* **Speculative PR chip** — a link to the combined test PR Trunk created for the stack (labeled **Stacked PR #N**). Click it to open the speculative PR on GitHub and inspect its CI status.
* **Stacked PR chip** — a link to the combined PR Trunk creates for the stack (labeled **Stacked PR #N**). Click it to open the stacked PR on GitHub and inspect its CI status.

Also note the small tense fix (Trunk createdTrunk creates) since this describes general behavior rather than a past event.

Comment thread merge-queue/chrome-extension.md Outdated
Comment on lines +60 to +62
{% hint style="info" %}
Stacked PR queue support requires the [Trunk Sudo GitHub App](../setup-and-administration/trunk-sudo-app.md) and the `/trunk stack` workflow. Stacks submitted one PR at a time with `/trunk merge` are tracked individually, not as a group.
{% endhint %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion — surface the prerequisite earlier. Readers learn at the very end of the section that the whole flow requires Trunk Sudo and the /trunk stack workflow. The rest of this page (lines 8–10) follows the convention of placing prerequisite hints at the top so readers don't get partway through before discovering they can't use the feature.

Consider moving this {% hint style="info" %} block to immediately after the ### Stacked pull requests heading, before "What the panel shows."

Comment thread merge-queue/chrome-extension.md Outdated

**Actions:**

* **Add to Merge Queue** — enqueues the entire stack as one unit. Any PR page in the stack triggers the same operation.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor — "Any PR page in the stack triggers the same operation" is slightly ambiguous (the page itself doesn't trigger anything; clicking the button does). Consider tightening:

Suggested change
* **Add to Merge Queue** — enqueues the entire stack as one unit. Any PR page in the stack triggers the same operation.
* **Add to Merge Queue** — enqueues the entire stack as one unit. Clicking it on any member PR page submits the same stack.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @samgutentag's task in 1m 8s —— View job


Claude PR Review

  • Read the current state of the changed file
  • Diff against origin/main to see latest changes
  • Verify whether prior review feedback was addressed
  • Check for new typos, grammar, formatting issues
  • Post review feedback

Summary

The latest push (56e75db) is a merge of main into the branch — no content changes were made to merge-queue/chrome-extension.md since my earlier review. All three issues I flagged previously still apply, and the inline comments on lines 56, 60, and 67 remain unresolved.

Outstanding issues

  1. Terminology inconsistency on line 56 (blocking) — the bullet still calls the UI element a "Speculative PR chip" while the same sentence labels it "Stacked PR #N" and tells the reader to click to "open the speculative PR." The companion page using-the-queue/stacked-pull-requests.md consistently uses stacked PR for this combined PR (verified — "speculative" appears there only in the unrelated predictive-testing context on line 142). Using both names in one sentence will confuse readers. See the inline suggestion block on line 56.
  2. Tense on line 56 — "the combined test PR Trunk created" → "Trunk creates" (general behavior, not a past event). Bundled into the same suggestion.
  3. Hint placement (lines 65–67) (non-blocking style) — the Trunk Sudo / /trunk stack prerequisite is still at the bottom of the section. The page convention (lines 8–10) puts prerequisite hints up top so readers don't get partway through before discovering they can't use the feature. Consider moving the {% hint %} directly under the ### Stacked pull requests heading.
  4. Wording on line 60 (non-blocking) — "Any PR page in the stack triggers the same operation" is slightly ambiguous (the page doesn't trigger anything; the click does). A tightened version is suggested in the inline comment.

What looks good

  • Heading capitalization (### Stacked pull requests) matches the page's sentence-case style.
  • Em-dash usage matches the existing convention.
  • Bold UI labels (**Add to Merge Queue**, **Cancel**) are consistent with neighboring sections.
  • Cross-references to using-the-queue/stacked-pull-requests.md#merge-the-stack-as-one-unit and ../setup-and-administration/trunk-sudo-app.md resolve correctly.

Setting review_passed = false — issue 1 is the same in-sentence terminology contradiction flagged before, and it's still a real reader-confusion problem that should be resolved before publishing. Issues 3 and 4 are style suggestions and not blockers on their own.

Fix issue 1 →
Branch

@samgutentag
Copy link
Copy Markdown
Member Author

Verification status (2026-05-06): live

Verified: customers can use this. Ready to publish.

  • Eng PR: trunk-io/trunk2#3825 (merged 2026-05-05)
  • Flag: none
  • Signals:
    • Merge commit on main (status: behind, merge intact)
    • No feature flag in eng PR body or diff (browser extension ships changes unflagged)

Branch state: up to date with main.

Suggested next action: merge.

samgutentag and others added 3 commits May 7, 2026 11:36
…source

Address fact-check findings from review pass:

- Use the actual button labels from the extension source: Add stack to
  queue (not Add to Merge Queue) and Remove (not Cancel)
- Rename Speculative PR chip to Stacked PR chip to match the visible
  Stacked PR #N label
- Switch to present tense for Trunk's stack-PR creation
- Move the Trunk Sudo prerequisite hint to the top of the section to
  match the rest of the page
- Tighten the Add stack to queue copy
- Add "enqueues" to the vale vocabulary so it stops flagging as a typo

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@samgutentag samgutentag changed the title docs(merge-queue): add stacked PR support section to Chrome Extension page [ready to merge] docs(merge-queue): add stacked PR support section to Chrome Extension page May 7, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 7, 2026

Claude finished @samgutentag's task in 1m 29s —— View job


Claude PR Review

  • Read the current state of the changed file
  • Diff against origin/main to see latest changes
  • Verify whether prior review feedback was addressed
  • Check for new typos, grammar, formatting issues
  • Post review feedback

Summary

The latest push (8e9b08a — "correct stacked-PR section against extension source") resolves every issue flagged in the prior reviews and goes further by reconciling the button labels against the actual extension source. This PR is ready to merge.

Prior issues — all resolved

  1. Terminology consistency ✓ — line 60 now reads **Stacked PR chip** — a link to the combined test PR Trunk creates for the stack (labeled **Stacked PR #N**). Click it to open the stacked PR on GitHub …. "Speculative" is gone; "stacked PR" is used consistently and matches the companion page using-the-queue/stacked-pull-requests.md.
  2. Tense fix ✓ — "Trunk creates" replaces "Trunk created" (general behavior, not a past event).
  3. Hint placement ✓ — the Trunk Sudo / /trunk stack prerequisite (lines 51–53) is now directly under the ### Stacked pull requests heading, matching the page convention at lines 8–10.
  4. Wording on Add-to-queue bullet ✓ — line 64 now reads **Add stack to queue** — enqueues the entire stack as one unit. Clicking it on any member PR page submits the same stack., matching the previously suggested phrasing.

Additional observations on this push

  • Button labels were corrected against the extension sourceAdd to Merge QueueAdd stack to queue, and CancelRemove. These differ from the labels in the Submit a pull request to the queue / Remove a pull request from the queue sections above, but per the commit message that's because the extension genuinely shows different labels in the stacked-PR view. Trusting the author's verification against the source.
  • Vale vocab additionenqueues added to .trunk/configs/vale/styles/config/vocabularies/terms/accept.txt to silence a false-positive typo flag from the new bullet. Consistent with the existing enqueueing and (?i)enqueued entries on adjacent lines.
  • Style consistency ✓ — sentence-case heading, spaced em-dashes, bold UI labels, and the using-the-queue/stacked-pull-requests.md#merge-the-stack-as-one-unit deep link all match neighboring sections.
  • Re-enqueue note (line 67) — slightly redundant with line 64 since both say "click on any member PR page," but it explicitly calls out the post-remove use case, so it earns its keep. Non-blocking.

What looks good

  • The section now reads as a coherent, fact-checked addition that mirrors the rest of the page's voice.
  • Cross-references resolve correctly.
  • No typos, grammar issues, or broken markdown.

Setting review_passed = true — all previously blocking issues are resolved and no new issues were introduced.
Branch

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

@samgutentag samgutentag marked this pull request as ready for review May 7, 2026 22:31
@samgutentag samgutentag merged commit fb6254a into main May 7, 2026
7 checks passed
@samgutentag samgutentag deleted the sam-gutentag/browser-extension-stacked-prs branch May 7, 2026 22:32
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 7, 2026

Claude finished @samgutentag's task in 1m 13s —— View job


Claude PR Review

  • Read the current state of the changed files
  • Diff against origin/main to see latest changes
  • Verify whether prior review feedback was addressed
  • Check for new typos, grammar, formatting issues
  • Post review feedback

Summary

This PR was merged as commit fb6254a on 2026-05-07. The merged content matches the state approved in the prior review (8e9b08a) — every previously-flagged issue is resolved in the final version on main.

Verified on the merged file (merge-queue/chrome-extension.md)

  1. Terminology consistency ✓ — line 60 uses Stacked PR chip consistently with the companion page using-the-queue/stacked-pull-requests.md. "Speculative" is no longer used to describe this chip.
  2. Tense ✓ — "the combined test PR Trunk creates" (general behavior, not past event).
  3. Hint placement ✓ — the Trunk Sudo / /trunk stack prerequisite (lines 51–53) sits directly under the ### Stacked pull requests heading, matching the page's existing convention at lines 8–10.
  4. Bullet wording ✓ — line 64 reads **Add stack to queue** — enqueues the entire stack as one unit. Clicking it on any member PR page submits the same stack.
  5. Button labels ✓ — Add stack to queue / Remove (per the extension's actual stacked-PR view, not the single-PR view's Add to Merge Queue / Cancel).
  6. Vale vocab ✓ — enqueues was added to .trunk/configs/vale/styles/config/vocabularies/terms/accept.txt alongside the existing enqueueing / (?i)enqueued entries.
  7. Cross-references ✓ — both using-the-queue/stacked-pull-requests.md#merge-the-stack-as-one-unit and ../setup-and-administration/trunk-sudo-app.md resolve.
  8. Style ✓ — sentence-case heading, spaced em-dashes, bold UI labels — all match neighboring sections.

No typos, grammar issues, or broken markdown in the merged content.

Setting review_passed = true. The PR is already merged; this is a confirmation that the merged state is clean.
Branch

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

trunk-staging-io Bot pushed a commit that referenced this pull request May 7, 2026
#643)

## Summary

Pulls forward the small bits worth keeping from #588 (Eli's original
Chrome Extension docs PR), since the page itself has evolved well past
that draft via several subsequent merged PRs (#593, #595, #598, #626,
#639).

## Changes

- Add a frontmatter `description:` so GitBook renders proper page
metadata for SEO and navigation previews
- Add an inline pointer to the Submit and cancel pull requests reference
page after the Submit steps, so readers can drill into the full
lifecycle from this entry point
- Replace the FAQ link to a hard-coded GitHub commit URL with a relative
path to `getting-started/`, matching the rest of the docs

## Test plan

- [ ] Verify the page metadata description renders in GitBook preview
- [ ] Confirm the new inline link to `using-the-queue/reference.md`
resolves correctly
- [ ] Confirm the FAQ link to `getting-started/` resolves correctly

## Related

- Closes #588 in spirit (that PR's content has been superseded by main;
this picks up the pieces still worth merging)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants