[ready to merge] docs(merge-queue): add stacked PR support section to Chrome Extension page#598
Conversation
… page Documents the new stack-aware view added to the browser extension for stacked PRs queued with /trunk stack: stack path display, speculative PR chip, and enqueue/cancel behavior for the whole stack. Source: trunk-io/trunk2#3825 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Claude finished @samgutentag's task in 2m 0s —— View job Claude PR Review
SummaryThe new Stacked pull requests section is well-scoped, scannable, and matches the page's existing voice and em-dash style. Cross-references (
What looks good
Setting |
| **What the panel shows:** | ||
|
|
||
| * **Stack path** — the full list of PRs in the stack from tip to base, so you can see where your PR sits within the group. | ||
| * **Speculative PR chip** — a link to the combined test PR Trunk created for the stack (labeled **Stacked PR #N**). Click it to open the speculative PR on GitHub and inspect its CI status. |
There was a problem hiding this comment.
Terminology inconsistency. This bullet describes the chip as a "Speculative PR chip" but in the same sentence says it is "labeled Stacked PR #N", and asks readers to click to "open the speculative PR." The companion page using-the-queue/stacked-pull-requests.md uses stacked PR consistently for this combined PR (the word "speculative" never describes this PR there — it only appears in the predictive-testing context).
Recommend renaming the chip and aligning the description with the rest of the docs:
| * **Speculative PR chip** — a link to the combined test PR Trunk created for the stack (labeled **Stacked PR #N**). Click it to open the speculative PR on GitHub and inspect its CI status. | |
| * **Stacked PR chip** — a link to the combined PR Trunk creates for the stack (labeled **Stacked PR #N**). Click it to open the stacked PR on GitHub and inspect its CI status. |
Also note the small tense fix (Trunk created → Trunk creates) since this describes general behavior rather than a past event.
| {% hint style="info" %} | ||
| Stacked PR queue support requires the [Trunk Sudo GitHub App](../setup-and-administration/trunk-sudo-app.md) and the `/trunk stack` workflow. Stacks submitted one PR at a time with `/trunk merge` are tracked individually, not as a group. | ||
| {% endhint %} |
There was a problem hiding this comment.
Suggestion — surface the prerequisite earlier. Readers learn at the very end of the section that the whole flow requires Trunk Sudo and the /trunk stack workflow. The rest of this page (lines 8–10) follows the convention of placing prerequisite hints at the top so readers don't get partway through before discovering they can't use the feature.
Consider moving this {% hint style="info" %} block to immediately after the ### Stacked pull requests heading, before "What the panel shows."
|
|
||
| **Actions:** | ||
|
|
||
| * **Add to Merge Queue** — enqueues the entire stack as one unit. Any PR page in the stack triggers the same operation. |
There was a problem hiding this comment.
Minor — "Any PR page in the stack triggers the same operation" is slightly ambiguous (the page itself doesn't trigger anything; clicking the button does). Consider tightening:
| * **Add to Merge Queue** — enqueues the entire stack as one unit. Any PR page in the stack triggers the same operation. | |
| * **Add to Merge Queue** — enqueues the entire stack as one unit. Clicking it on any member PR page submits the same stack. |
|
Claude finished @samgutentag's task in 1m 8s —— View job Claude PR Review
SummaryThe latest push ( Outstanding issues
What looks good
Setting |
|
Verification status (2026-05-06): Verified: customers can use this. Ready to publish.
Branch state: up to date with main. Suggested next action: merge. |
…extension-stacked-prs
…extension-stacked-prs
…source Address fact-check findings from review pass: - Use the actual button labels from the extension source: Add stack to queue (not Add to Merge Queue) and Remove (not Cancel) - Rename Speculative PR chip to Stacked PR chip to match the visible Stacked PR #N label - Switch to present tense for Trunk's stack-PR creation - Move the Trunk Sudo prerequisite hint to the top of the section to match the rest of the page - Tighten the Add stack to queue copy - Add "enqueues" to the vale vocabulary so it stops flagging as a typo Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @samgutentag's task in 1m 29s —— View job Claude PR Review
SummaryThe latest push ( Prior issues — all resolved
Additional observations on this push
What looks good
Setting |
|
Claude finished @samgutentag's task in 1m 13s —— View job Claude PR Review
SummaryThis PR was merged as commit Verified on the merged file (
|
#643) ## Summary Pulls forward the small bits worth keeping from #588 (Eli's original Chrome Extension docs PR), since the page itself has evolved well past that draft via several subsequent merged PRs (#593, #595, #598, #626, #639). ## Changes - Add a frontmatter `description:` so GitBook renders proper page metadata for SEO and navigation previews - Add an inline pointer to the Submit and cancel pull requests reference page after the Submit steps, so readers can drill into the full lifecycle from this entry point - Replace the FAQ link to a hard-coded GitHub commit URL with a relative path to `getting-started/`, matching the rest of the docs ## Test plan - [ ] Verify the page metadata description renders in GitBook preview - [ ] Confirm the new inline link to `using-the-queue/reference.md` resolves correctly - [ ] Confirm the FAQ link to `getting-started/` resolves correctly ## Related - Closes #588 in spirit (that PR's content has been superseded by main; this picks up the pieces still worth merging) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Adds a "Stacked pull requests" section to the Chrome Extension docs explaining the new stack-aware panel: stack path display, speculative PR chip with link, and enqueue/cancel behavior that applies to the whole stack. Includes a hint linking to Trunk Sudo requirements.
Source
Test plan
Generated by Claude Code